indent

[cjohns at plessey.com.au (Chris Johns)]

Quality Quorum wrote:
> 
> Hi,
> 
> I took about 1 minute to execute
> 
> find . -name '*.[hc]' -exec indent {} \;
> 
> from rtems-980824/c/src on P166/32MB/Linux.
> 
> It generated some error messages, which are attached.
> 

I have to say, I am not sure about this sort of change entering the
code just before a release. I do not consider code formatting a bug so
I am wondering why this is being done.

I will have to maintain the code for C++. I know what the code
currently looks like and I would kind of like it to stay that way for
this release.

What happens post 4.0 is of course another issue.
 
>   ----------------------------------------------------------------------

> indent:./lib/include/rtems++/rtemsMessageQueue.h:17: Warning: Extra }

Line 17 in this file is in the middle of a comment. The comment starts
at the beginning of the file.

Are you sure ident is ok ?

> indent:./lib/include/rtems++/rtemsMessageQueue.h:121: Error: Stuff missing from end of file.

Nice error messasge. Compiles ok with egcs. I kinda think I will go
with what egcs says.

> indent:./lib/include/rtems++/rtemsSemaphore.h:23: Warning: Extra }
> indent:./lib/include/rtems++/rtemsSemaphore.h:93: Error: Stuff missing from end of file.

Same again.

> indent:./lib/include/rtems++/rtemsTask.h:17: Warning: Extra }
> indent:./lib/include/rtems++/rtemsTask.h:95: Error: Stuff missing from end of file.

Same again.

> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:126: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:159: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:161: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:164: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:173: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:180: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:183: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:185: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:187: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:189: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:191: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:199: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:201: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:202: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:204: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:206: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:212: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:218: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:222: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:225: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:227: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:293: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:298: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:303: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:305: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:308: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:311: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:367: Error: Unterminated string constant
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:407: Error: Unmatched 'else'
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:457: Error: Unmatched 'else'
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:470: Error: Stmt nesting error.
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:500: Error: Stmt nesting error.
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:607: Error: Unmatched 'else'
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:657: Error: Unmatched 'else'
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:693: Error: Unmatched 'else'
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:727: Error: Unmatched 'else'
> indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:889: Error: Stuff missing from end of file.

This was taken from gdb a gnu package.


-- 
 Chris Johns  Networks, Plessey Asia Pacfic Pty. Ltd.
  mailto:ccj at acm.org    mailto:cjohns at plessey.com.au