[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Date: Wed, 9 Sep 1998 11:31:01 -0500 (CDT)
- From: joel at OARcorp.com (joel at OARcorp.com)
- Subject: indent
On Wed, 9 Sep 1998, Chris Johns wrote:
> I have to say, I am not sure about this sort of change entering the
> code just before a release. I do not consider code formatting a bug so
> I am wondering why this is being done.
This will NOT be done before this release if it is done at all.
> I will have to maintain the code for C++. I know what the code
> currently looks like and I would kind of like it to stay that way for
> this release.
I think C++ may be offlimits as well.
> What happens post 4.0 is of course another issue.
Exactly. I am leaning toward a massive merger after 4.0. I personally
have libchip and the in-memory file system with (hopefully) the
infrastructure to manage a real file system.
> > indent:./lib/include/rtems++/rtemsMessageQueue.h:17: Warning: Extra }
> Line 17 in this file is in the middle of a comment. The comment starts
> at the beginning of the file.
> Are you sure ident is ok ?
Probably for C and nothing else.
> > indent:./lib/include/rtems++/rtemsMessageQueue.h:121: Error: Stuff missing from end of file.
> Nice error messasge. Compiles ok with egcs. I kinda think I will go
> with what egcs says.
> > indent:./lib/include/rtems++/rtemsSemaphore.h:23: Warning: Extra }
> > indent:./lib/include/rtems++/rtemsSemaphore.h:93: Error: Stuff missing from end of file.
> Same again.
> > indent:./lib/include/rtems++/rtemsTask.h:17: Warning: Extra }
> > indent:./lib/include/rtems++/rtemsTask.h:95: Error: Stuff missing from end of file.
> Same again.
> > indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:693: Error: Unmatched 'else'
> > indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:727: Error: Unmatched 'else'
> > indent:./lib/libbsp/m68k/ods68302/startup/m68k-stub.c:889: Error: Stuff missing from end of file.
> This was taken from gdb a gnu package.
And is chockful of inline assembly (i.e. multline strings).
This would also be code to NOT change the style on.
- From: cjohns at plessey.com.au (Chris Johns)