[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

rtems-980923 is available





On Wed, 23 Sep 1998, Quality Quorum wrote:

> BTW, I think that you guys are also wrong on the matter of enforcing
> common style, let us not discuss both these issues, the thing will
> work either way. I am just appalled by the level of nitpicking I saw 
> today.

The view from the top on style:

I try to make sure that the style in shared parts of the tree (BSP
independent) are consistent stylistically if the code is new for RTEMS.
If a BSP is submitted, I will likely not touch the style.  I will add CVS
Id's, fix grammar and spelling in comments, etc..

If the code is from another source (FreeBSD stack for example), the goal
is to minimize changes to the source so diff's against future versions
will be possible.

On termios.c dequeue's return value:

I have NEVER seen anything in RTEMS so small generate so much discussion.
:)  It needs to indicate whether or not the TX interrupt should be
disabled.

In the libchip drivers for the z8530, mc68681, and ns16550, I could get by
with a "yes/no" answer to the question: "Are there more characters to TX?"
When would you need to know more than this?

--joel