[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

i386ex: pc386 references



>>>>> "erik" == erik ivanenko <erik.ivanenko at utoronto.ca> writes:

erik> I would also remove the "pc386_" references everywhere, or replace with BSP_.
erik> I'd not add the i8259 references either, I don't see the point of having them.

erik> A few test subsitutions give us names like:

erik> BSP_irq_enabled_at_i8259s
erik> BSP_install_rtems_irq_handler
erik> BSP_irq_disable_at_i8259s
erik> BSP_irq_enable_at_i8259s

erik> i386_delete_idt_entry <- from libcpu
erik> i386_set_idt_entry    <- from libcpu

erik> BSP_irq_ack_at_i8259s
erik> BSP_get_current_rtems_irq_handler

erik> BSP_remove_rtems_irq_handler
erik> BSP_rtems_irq_mngt_set

erik> BSP_install_rtems_irq_handler

As far as I'm concerned I agree. 

erik> i386_isr_entry set_vector <- from i386ex/startup/setvec.c /* I should change this
erik> name or remove this function I don't think it is needed!!! */

Joel insisted to put it back for "compatibility" reasons...

--  eric