[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

rtems-980923 is available




On Wed, 23 Sep 1998, VALETTE Eric wrote:

> 
>   /* Initialize video */
>   _IBMPC_initVideo();
> 
> in lib/libbsp/i386/pc386/console/console.c::console_initialize is here 
> again. Because it is aready done in lib/libbsp/i386/pc386/startup/bspstart::bsp_start
> calling it again may makes some usefull message disappear. I vote for 
> DEFINITIVE removal. At least I would like to know why someone make it 
> appear again each time I send a patch to remove it. Aleksey do you have any
> reason? (I mean except not applying the patch I submit before sumitting yours)

This could just be frustration on Aleksey's part that pieces of his (and
your) patches are not getting in the snapshots.  

 I think the patches have been impacting the same files just enough to
keep me from being able to reliably merging them.   Then both of you are
inclined to do the minimum necessary to get a working BSP and send me a
diff.  It is just as difficult to keep up on that side of the equation.

I cut this snapshot quick to avoid the problems from conflicting and
interrelated patches.

Back to the subject, I don't see any reason why this should be initialized
twice.  If it is necessary to do it twice, then there is a problem.

I will wait to hear from ALeksey before removing this though.

--joel