double check me on this

[jskulpin at eng01.gdds.com (Jay Kulpinski)]

>
>
> I looked over a diff of the network stack from 4.0.0 until now and came
> across a change I made to sys/mbuf.h.  In the original code, they used
> names like "m" as macro parameters.  I changed all macro parameters to
> _XXX to avoid naming conflicts.  If I messed up, I could have broken
> something.  Here is a sample from the diff:
>
> 316,317c319,320
> < #define       MH_ALIGN(m, len) \
> <       { (m)->m_data += (MHLEN - (len)) &~ (sizeof(long) - 1); }
> ---
> > #define       MH_ALIGN(_m, _len) \
> >       { (_m)->m_data += (MHLEN - (_len)) &~ (sizeof(long) - 1); }
>
> If you can double check me on this change, I would appreciate it.  All you
> should have to do is diff sys/mbuf.h from 4.0.0 to the one in 19990426 and
> make sure I did the substitutions right.  
>
> I doubt I broke anything but it does not hurt to check.
>
> Thanks.
>
> --joel
>
>
>

Joel,

I did already run a recursive diff of libnetworking and didn't find 
anything that looked like a problem.  I thought all of the 
"m" to "_m" and similar changes were okay.  Inserting code to delay
the transmitUdp sufficiently "fixes" the problem and allows all
of the packets to go out.  I also compiled my net device driver
without any optimization (but not the whole network stack) to 
try to eliminated problems with volatility in the compilation,
but the problem still occurred.

I'll be trying to use a counting semaphore to keep track of 
busy clusters.  I'll have to wait for this old creaky Pentium 90
to finish first.  I hope this won't violate any internet RFCs
or anything.

- Jay